IT-Works/sssd-configuration
1
0
Fork 0
Code Actions

fix shellcheck results
All checks were successful
Sonarqube Scanner / Build and analyze (push) Successful in 26s
Details

Browse Source
This commit is contained in:
Florian Zumpe 2026-06-08 14:27:19 +02:00
parent fb182b2ffc
commit f455fdb591
2 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
LICENSE
View File

@ -1,11 +1,11 @@
Proprietary License Proprietary License
Copyright (c) 2026 Florian Zumpe. All rights reserved. Copyright (c) 2026 Florian Zumpe. All rights reserved.
Permission is granted to the recipient to run this script locally for its intended Permission is granted to the recipient to run this script locally for its intended
purpose. purpose.
No permission is granted to copy, modify, distribute, sublicense, publish, sell, No permission is granted to copy, modify, distribute, sublicense, publish, sell,
lease, host, or otherwise make this script available to third parties. lease, host, or otherwise make this script available to third parties.
The script is provided "as is", without warranty of any kind. The script is provided "as is", without warranty of any kind.

12
domain-join.sh
View File

@ -375,7 +375,9 @@ configure_dns() {
fi fi
log "Discovered DNS server IPs:" log "Discovered DNS server IPs:"
printf ' - %s\n' $dns_ips while IFS= read -r ip; do
[[ -n "$ip" ]] && printf ' - %s\n' "$ip"
done <<< "$dns_ips"
if systemctl is-active --quiet systemd-resolved 2>/dev/null; then if systemctl is-active --quiet systemd-resolved 2>/dev/null; then
log "Configuring DNS via systemd-resolved drop-in (/etc/systemd/resolved.conf.d/)" log "Configuring DNS via systemd-resolved drop-in (/etc/systemd/resolved.conf.d/)"
@ -558,8 +560,8 @@ keyring_is_working() {
keyctl show >/dev/null 2>&1 || return 1 keyctl show >/dev/null 2>&1 || return 1
# Write test: create new session + dummy key in @s # Write test: create new session + dummy key in @s
local sid kid local kid
sid="$(keyctl new_session 2>/dev/null)" || return 1 keyctl new_session >/dev/null 2>&1 || return 1
kid="$(printf 'ping' | keyctl padd user adjoin-key-test @s 2>/dev/null)" || return 1 kid="$(printf 'ping' | keyctl padd user adjoin-key-test @s 2>/dev/null)" || return 1
keyctl unlink "$kid" @s >/dev/null 2>&1 || true keyctl unlink "$kid" @s >/dev/null 2>&1 || true
@ -1023,7 +1025,9 @@ log "DNS check: SRV lookup _ldap._tcp.${AD_DOMAIN_FQDN}"
DC_LIST="$(discover_dcs "${AD_DOMAIN_FQDN}" || true)" DC_LIST="$(discover_dcs "${AD_DOMAIN_FQDN}" || true)"
if [[ -n "$DC_LIST" ]]; then if [[ -n "$DC_LIST" ]]; then
log "Discovered Domain Controllers (via SRV):" log "Discovered Domain Controllers (via SRV):"
printf ' - %s\n' $DC_LIST while IFS= read -r dc; do
[[ -n "$dc" ]] && printf ' - %s\n' "$dc"
done <<< "$DC_LIST"
else else
warn "No DCs found via SRV. Join will likely fail (DNS not AD-capable?)." warn "No DCs found via SRV. Join will likely fail (DNS not AD-capable?)."
fi fi