fix sonarqube findings

src/services/gpx.js

@@ -52,7 +52,8 @@ export function parseGpx(xml, replacementPoints = null) {
   const points = replacementPoints ?? (routed.length ? routed : simplifyTrack(recorded));
   const waypoints = validPoints(asList(gpx.wpt));
   if (!points.length && !waypoints.length && !gpx.extensions?.['wegwichtel:gpsGap'] && !gpx.extensions?.['wegwichtel:pendingWaypoint']) throw new HttpError(400, 'Die GPX-Datei enthält keine verwertbaren Punkte.');
-  const metrics = points.length || waypoints.length ? routeMetrics(points.length ? points : waypoints) : {
+  const metricPoints = points.length ? points : waypoints;
+  const metrics = metricPoints.length ? routeMetrics(metricPoints) : {
     startLat: null, startLon: null, centerLat: null, centerLon: null,
     minLat: null, minLon: null, maxLat: null, maxLon: null,
     distanceM: 0, elevationGainM: 0, pointCount: 0
@@ -63,6 +64,8 @@ export function parseGpx(xml, replacementPoints = null) {
   delete gpx.rte;
   // GPX 1.1 order: metadata, waypoints, route, extensions.
   const { extensions, ...base } = gpx;
+  // GPX 1.1 namespace identifier: this URI is written into XML, never fetched.
+  // Its exact spelling is part of the GPX standard; HTTPS would be another namespace.
   const normalized = { ...base, '@_version': '1.1', '@_creator': 'Wegwichtel', '@_xmlns': 'http://www.topografix.com/GPX/1/1' };
   if (points.length) normalized.rte = { ...(name ? { name } : {}), rtept: points.map(point => ({
     '@_lat': point.lat, '@_lon': point.lon,
@@ -75,13 +78,15 @@ export function parseGpx(xml, replacementPoints = null) {
 
 export function gpxWithWaypoints(xml, pois) {
   const gpx = parseXml(xml).gpx;
-  const { wpt: _oldWaypoints, rte, trk, extensions = {}, ...base } = gpx;
+  delete gpx.wpt;
+  const { rte, trk, extensions = {}, ...base } = gpx;
   const waypoint = poi => ({ '@_lat': poi.lat, '@_lon': poi.lon, name: poi.title,
     ...(poi.description ? { desc: poi.description } : {}),
     extensions: { 'wegwichtel:poiId': poi.id } });
   const located = pois.filter(poi => Number.isFinite(poi.lat) && Number.isFinite(poi.lon));
   const pending = pois.filter(poi => !Number.isFinite(poi.lat) || !Number.isFinite(poi.lon));
-  const { 'wegwichtel:pendingWaypoint': _oldPending, ...extra } = extensions;
+  const extra = { ...extensions };
+  delete extra['wegwichtel:pendingWaypoint'];
   if (pending.length) extra['wegwichtel:pendingWaypoint'] = pending.map(poi => ({ name: poi.title,
     ...(poi.description ? { desc: poi.description } : {}), extensions: { 'wegwichtel:poiId': poi.id } }));
   const normalized = { ...base, '@_xmlns:wegwichtel': 'urn:wegwichtel:poi',