added image and audio REST endpoints

test/api-docs.test.js

@@ -25,6 +25,15 @@ test('complete REST API documentation is kept outside the README', async () => {
     'POST /api/routes/:id/append',
     'POST /api/routes/:id/pois',
     'PUT /api/pois/:id',
+    'GET /api/routes/:id/pictures',
+    'GET /api/routes/:id/pictures/:pictureId',
+    'POST /api/routes/:id/pictures',
+    'PUT /api/routes/:id/pictures/:pictureId',
+    'DELETE /api/routes/:id/pictures/:pictureId',
+    'GET /api/routes/:id/audio',
+    'POST /api/routes/:id/audio',
+    'PUT /api/routes/:id/audio',
+    'DELETE /api/routes/:id/audio',
     'DELETE /api/routes/:id',
     'POST /api/routes/:id/restore'
   ]) {
@@ -34,8 +43,28 @@ test('complete REST API documentation is kept outside the README', async () => {
   for (const parameter of [
     'lat', 'lon', 'radiusKm', 'includeDeleted', 'gpx', 'name', 'slug',
     'description', 'schoolName', 'title', 'triggerRadiusM', 'sequence',
-    'audio', 'images'
+    'picture', 'pictureId', 'caption', 'audio', 'poiId'
   ]) {
     assert.match(api, new RegExp(`\\b${parameter}\\b`), `missing parameter documentation: ${parameter}`);
   }
 });
+
+test('POI media uploads use dedicated single-resource endpoints', async () => {
+  const router = await read('src/routes/api.js');
+  const routesService = await read('src/services/routes-service.js');
+  const mediaService = await read('src/services/media-service.js');
+
+  assert.match(router, /post\('\/routes\/:id\/pictures', upload\.single\('picture'\)/);
+  assert.match(router, /put\('\/routes\/:id\/pictures\/:pictureId', upload\.single\('picture'\)/);
+  assert.match(router, /delete\('\/routes\/:id\/pictures\/:pictureId'/);
+  assert.match(router, /post\('\/routes\/:id\/audio', upload\.single\('audio'\)/);
+  assert.match(router, /put\('\/routes\/:id\/audio', upload\.single\('audio'\)/);
+  assert.match(router, /delete\('\/routes\/:id\/audio'/);
+  assert.match(router, /post\('\/routes\/:id\/pois', upload\.none\(\)/);
+  assert.doesNotMatch(routesService, /files\.images|files\.audio/);
+  assert.match(mediaService, /caption/);
+  assert.match(mediaService, /removeStoredFile/);
+  assert.match(mediaService, /pictureApiUrl/);
+  assert.match(mediaService, /audioApiUrl/);
+  assert.doesNotMatch(router, /audio\/:poiId/);
+});