cleanup and fix sonarqube findings

2026-06-04 23:54:22 +02:00
parent d7ce563925
commit dd1b08ee21
5 changed files with 54 additions and 19 deletions
@@ -236,7 +236,6 @@ export class ConfigurableReactionsConfigApp extends HandlebarsApplicationMixin(A

        if (dropZone.dataset.crDrop === "action-spell" && isSpellItem(droppedItem)) {
          await this.#setActionSpell(Number(dropZone.dataset.actionIndex), droppedItem);
-          return;
        }
      });
    }
@@ -409,6 +408,7 @@ export class ConfigurableReactionsConfigApp extends HandlebarsApplicationMixin(A
    try {
      reaction = JSON.parse(textarea.value);
    } catch (error) {
+      console.warn(`${MODULE_ID} | Invalid reaction JSON`, error);
      ui.notifications.error(game.i18n.localize("CONFIGURABLE_REACTIONS.Errors.InvalidJson"));
      return false;
    }